github-actions[bot] commented on code in PR #68978:
URL: https://github.com/apache/doris/pull/68978#discussion_r4248054769
##########
be/test/exprs/function/function_round_test.cpp:
##########
@@ -1197,6 +1197,22 @@ TEST(RoundFunctionTest, decimal_scale_boundaries) {
0, -1, false,
true);
}
+TEST(RoundFunctionTest, decimal_rounding_overflow) {
Review Comment:
[P1] Update legacy CEIL expectations for the new exception
The first `ceil_decimal32_cases` entry (line 358) still expects zero for raw
input 1, input scale 0, and requested scale -10. Both factors now saturate to
`INT32_MAX`, so the new positive-CEIL branch throws. `decimal_checker` calls
`execute_impl` without an exception expectation (line 1020), and both
`normal_decimal` and `normal_decimal_const` use that dataset. Thus this
isolated `EXPECT_THROW` leaves both existing test groups failing and aborts
their remaining cases. Split/update the overflowing CEIL cases to assert the
arithmetic-overflow error in this PR while retaining the representable-result
checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
