yiguolei commented on code in PR #68610:
URL: https://github.com/apache/doris/pull/68610#discussion_r4253986011
##########
be/src/exec/scan/scanner_context.cpp:
##########
@@ -604,6 +604,14 @@ bool ScannerContext::can_admit_scan_task(const
std::unique_lock<std::mutex>& tra
if (done() || _pending_tasks.empty()) {
return false;
}
+ // Same rule as _pull_next_scan_task() on the TaskExecutor path: once the
shared LIMIT is
Review Comment:
这里做这种逻辑判断容易有问题，就是scanner 调度容易卡死。
我们可以先忍受一下把scanner 调度起来。然后再Scanner::get_block_after_projects 这个方法中去判断shared
scan limit 是不是exhausted，然后返回一个空block，这样scan operator 那里之前出现的一些调度问题就不会有了。
依赖_in_flight_tasks_num 类似的变量，特别容易出错。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
