wyxxxcat commented on code in PR #68967:
URL: https://github.com/apache/doris/pull/68967#discussion_r4254322509
##########
cloud/src/recycler/s3_accessor.cpp:
##########
@@ -325,15 +325,7 @@ std::string S3Accessor::to_uri(const std::string&
relative_path) const {
int S3Accessor::create(S3Conf conf, std::shared_ptr<S3Accessor>* accessor) {
TEST_SYNC_POINT_RETURN_WITH_VALUE("S3Accessor::init.s3_init_failed",
(int)-1);
- switch (conf.provider) {
- case S3Conf::GCS:
- *accessor = std::make_shared<GcsAccessor>(conf);
- break;
- default:
- *accessor = std::make_shared<S3Accessor>(conf);
- break;
- }
-
+ *accessor = std::make_shared<S3Accessor>(conf);
Review Comment:
The DeleteObjects of AWS S3 and GCS may both return HTTP 404 when bucket is
removed, which is consistent with the existing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
