github-actions[bot] commented on code in PR #68996:
URL: https://github.com/apache/doris/pull/68996#discussion_r4255439649
##########
.github/scripts/submit_review.py:
##########
@@ -49,9 +49,25 @@ def priority(body):
def validate_submission(value):
if not isinstance(value, dict) or set(value) != {
- "body", "comments", "existing_blocking_comment_ids"
+ "body", "comments", "existing_blocking_comment_ids",
+ "converged", "rounds", "incomplete_reason"
Review Comment:
[P2] Update the remaining fake reviewer to the new submission schema
`FAKE_CODEX` in `.github/scripts/test_review_auth_quarantine.py:109` still
writes only `body`, `comments`, and `existing_blocking_comment_ids`, then
invokes the real `submit_review.py` with `check=True`. Requiring these three
new fields makes that subprocess raise before the fake emits its terminal
events, so both
`test_success_is_not_quarantined_even_with_earlier_stderr_error` and
`test_capacity_after_submission_is_success_without_auth_quarantine` fail on
Linux instead of exercising successful delivery. Add a valid `converged`,
`rounds`, and `incomplete_reason` declaration to that fixture as part of this
schema change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
