morningman commented on code in PR #69001:
URL: https://github.com/apache/doris/pull/69001#discussion_r4256101144
##########
fe/fe-core/src/test/java/org/apache/doris/common/util/BrokerUtilTest.java:
##########
@@ -125,4 +126,29 @@ public void parseColumnsFromPath() {
}
+ @Test
+ public void parseColumnsFromPathPreservesNullMetadataAndInputKeys() throws
Exception {
+ // A case-insensitive parse lowercases its own copy of the keys, not
the caller's list, and turns the Hive
+ // default partition into SQL NULL.
+ List<String> partitionKeys = Lists.newArrayList("region", "dt");
Review Comment:
Agreed, fixed in fe841c0c7de. The caller now passes `Region` and `Dt`, the
path spells them `REGION` and `dt`, and the test asserts the list still reads
`Region, Dt` after the case-insensitive parse.
Checked against the regression you describe: with `FilePartitionUtils`
lowercasing the caller's list in place
(`columnsFromPath.replaceAll(String::toLowerCase)`), the new assertion fails
(`expected: <[Region, Dt]> but was: <[region, dt]>`), while the old
all-lowercase fixture passed under the same change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
