wenzhenghu commented on PR #68740: URL: https://github.com/apache/doris/pull/68740#issuecomment-6162045290
Review follow-up for [the inline review](https://github.com/apache/doris/pull/68740#pullrequestreview-5497878377): all 7 discussions have individual replies and resolution dispositions. The update documents file/directory sync, lock waits, whole-BE termination, restart recovery, silent exit status 74, and fatal/teardown supervision. The poller is named `disk-watchdog`. The public duration-input validation was deliberately retained and explained inline. The timeout default remains `0`; the separate configuration-reference documentation PR is still a follow-up. Validation of the review-fix code included 17 ASAN watchdog/storage tests and a userspace probe-stall cluster test: exit 74, FE offline detection, remaining-replica reads/writes, and recovery to 9 healthy replicas. This did not reproduce RAID/kernel D-state faults. These tests preceded the later master merge; I refreshed the merged-head source for these replies rather than claiming a new full test run at that merge commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
