github-actions[bot] commented on code in PR #69031:
URL: https://github.com/apache/doris/pull/69031#discussion_r4270034234
##########
fe/pom.xml:
##########
@@ -360,7 +362,7 @@ under the License.
<!-- ATTN: avro version must be consistent with Iceberg version -->
<!-- Please modify iceberg.version and avro.version together,
you can find avro version info in iceberg mvn repository -->
- <iceberg.version>1.11.0</iceberg.version>
+ <iceberg.version>1.12.0</iceberg.version>
Review Comment:
[P2] Preserve legacy S3 signer settings when upgrading the SDK
An existing REST catalog can use `s3.remote-signing-enabled=true` with
`s3.signer.uri` and `s3.signer.endpoint` to read S3 metadata. Doris still
forwards those keys unchanged, but [Iceberg 1.12 removed their
readers](https://github.com/apache/iceberg/blob/apache-iceberg-1.12.0/aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java).
When a server returns empty load-table config/credentials without the new
remote-signing config, `RESTSessionCatalog.tableFileIO()` reuses catalog IO
before adding `rest.remote-signing.endpoint`; the first manifest read now fails
with `Remote signing endpoint is required`. With nonempty table config, the
automatic per-table endpoint instead ignores the configured signer host/path.
These configurations worked with 1.11, so the upgrade breaks catalog access.
Translate the legacy URI/endpoint keys before FileIO initialization (including
server-supplied config) and cover a remotely signed manifest read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
