wenzhenghu commented on code in PR #68694:
URL: https://github.com/apache/doris/pull/68694#discussion_r4267290607
##########
fe/fe-core/src/main/java/org/apache/doris/qe/AutoCloseConnectContext.java:
##########
@@ -17,15 +17,19 @@
package org.apache.doris.qe;
+import org.apache.doris.common.QueryLogContext;
+
public class AutoCloseConnectContext implements AutoCloseable {
public final ConnectContext connectContext;
private final ConnectContext previousContext;
+ private final QueryLogContext queryLogContext;
public AutoCloseConnectContext(ConnectContext connectContext) {
this.previousContext = ConnectContext.get();
this.connectContext = connectContext;
+ this.queryLogContext = QueryLogContext.open(connectContext.queryId());
Review Comment:
Addressed in
[e8c944b9cb66](https://github.com/apache/doris/commit/e8c944b9cb668c580b1854979a0225a04d80ef76).
`StreamingJobUtils.buildConnectContext()` no longer calls
`setThreadLocalInfo()`. Constructing the internal connection leaves the
caller's connection/MDC intact, and `AutoCloseConnectContext` owns installation
and restoration.
`testStreamingConnectionBuilderDoesNotReplaceCaller` verifies the builder
and scoped restoration; it passed in the independent FE run.
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -77,6 +77,9 @@ public class Config extends ConfigBase {
options = {"NORMAL", "ASYNC", "BRIEF"})
public static String sys_log_mode = "ASYNC";
+ @ConfField(description = "Attach query_id to runtime log events. Requires
restart.")
+ public static boolean sys_log_enable_query_id = true;
Review Comment:
Clarified in
[e8c944b9cb66](https://github.com/apache/doris/commit/e8c944b9cb668c580b1854979a0225a04d80ef76)
and the release note. The note now explicitly says that collectors depending
on the previous message text must adapt, and that disabling the prefix does not
restore migrated wording byte-for-byte. FE/BE configuration comments carry the
same warning.
The statement identifier, timeout/retry messages, and selected BE
start/cancel messages retain explicit fallback IDs when the prefix cannot
attribute them. Both prefix defaults remain `true`. A separate documentation PR
is still pending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
