OIiveirra commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4273981730
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/StIntersects.java:
##########
@@ -70,6 +70,12 @@ public List<FunctionSignature> getSignatures() {
return SIGNATURES;
}
+ @Override
+ public FunctionSignature searchSignature(List<FunctionSignature>
signatures) {
+ FunctionSignature signature =
SpatialFunctionSignature.binary(child(0), child(1), BooleanType.INSTANCE);
Review Comment:
Fixed in
[c844f46f09f](https://github.com/apache/doris/commit/c844f46f09f64eaacd68688876227eb877c0f1db).
Typed Geography line shape indexes retain only consecutive edges, with no
last-to-first edge for an open line. Closing edges are reserved for polygon
rings. Added the disjoint open-line/polygon reproducer in both operand orders;
both return false for Intersects. The targeted BE tests and GIS regression
passed locally.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/StAsBinary.java:
##########
@@ -68,6 +68,12 @@ public List<FunctionSignature> getSignatures() {
return SIGNATURES;
}
+ @Override
+ public FunctionSignature searchSignature(List<FunctionSignature>
signatures) {
+ FunctionSignature signature = SpatialFunctionSignature.unary(child(0),
VarcharType.SYSTEM_DEFAULT);
Review Comment:
Fixed in
[c844f46f09f](https://github.com/apache/doris/commit/c844f46f09f64eaacd68688876227eb877c0f1db).
The typed ST_AsBinary overload now returns FE VARBINARY with matching BE
DataTypeVarbinary/ColumnVarbinary handling. Added a direct Arrow test for both
typed kinds that checks Binary schema, exact WKB bytes and NULLs, without using
hex. Direct Unicode MySQL checks also pass for both projections. The legacy
STRING overload keeps its existing return contract, and the current EN/ZH docs
are updated in apache/doris-website#4239.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/StDisjoint.java:
##########
@@ -70,6 +70,12 @@ public List<FunctionSignature> getSignatures() {
return SIGNATURES;
}
+ @Override
+ public FunctionSignature searchSignature(List<FunctionSignature>
signatures) {
+ FunctionSignature signature =
SpatialFunctionSignature.binary(child(0), child(1), BooleanType.INSTANCE);
Review Comment:
Fixed in
[c844f46f09f](https://github.com/apache/doris/commit/c844f46f09f64eaacd68688876227eb877c0f1db).
Calculation copies now canonicalize date-line and pole positions while
preserving the original WKB. At +180 degrees only the longitude sine component
is flipped; latitude is not reconstructed, avoiding a second rounding
difference at nonzero latitudes. Added Intersects/Disjoint coverage for +/-180
aliases at zero and nonzero latitude, plus north/south pole longitude aliases.
Raw-accessor preservation tests and targeted BE tests passed locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
