github-actions[bot] commented on code in PR #68032: URL: https://github.com/apache/doris/pull/68032#discussion_r4278974499
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowDataCommand.java: ########## @@ -29,6 +30,7 @@ Review Comment: [P2] Preserve local SHOW DATA routing outside master-only warehouse totals. `ShowDataCommand.toRedirectStatus()` now returns `FORWARD_NO_SYNC` for every form, even `SHOW DATA FROM db.table` and shared-nothing/non-cloud executions whose code never reads `getRemoteSpillSize()`. A follower that previously served these local metadata queries now depends on the master FE and can fail or add an avoidable forwarding hop when the master is unavailable. Return the forwarding status only for cloud whole-warehouse/all-database paths that need the master-held remote spill total, and keep the prior `NO_FORWARD` behavior for the other forms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
