deardeng opened a new pull request, #69116:
URL: https://github.com/apache/doris/pull/69116
Related PR: #57072, #65658
Problem Summary: During BE startup, get_or_set, the fully-covered lookup,
and probe attempt to restore an absent file before background metadata loading
completes. Their FileCacheKey leaves offset uninitialized, while the storage
implementation now performs an exact RocksDB lookup for one block. A file with
multiple persisted blocks can therefore miss existing cache data or restore
only one block. Query metadata by tablet and file hash prefix, restore all
blocks, and assert that the file hash is absent when entering synchronous
restoration. Keep caller trigger conditions, key encoding, and existing
tablet-range queries unchanged.
Fix reuse of persistent file cache blocks while BE startup metadata loading
is in progress.
- Test: Unit Test via run-be-ut.sh with ASAN and GLIBC_COMPATIBILITY=OFF: 38
related tests passed; 9 focused tests passed again after final cleanup. The 5
startup regression cases failed before the fix and passed afterward.
clang-format v16, build hygiene, git diff checks, and clang-tidy on changed
lines passed.
- Behavior changed: Yes, startup lookups restore all persisted blocks for an
absent file instead of querying one uninitialized offset.
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
