github-actions[bot] commented on code in PR #69010:
URL: https://github.com/apache/doris/pull/69010#discussion_r4279756878
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -3653,6 +3653,21 @@ public void
checkAnnIndexCandidateRowsPercentThreshold(String value) {
description = "Enable merge partitioning for Iceberg UPDATE/DELETE
(INSERT by partition columns, "
+ "DELETE by row_id).")
public boolean enableIcebergMergePartitioning = true;
+
+ public static final String ICEBERG_PARTITION_OVERWRITE_MODE =
"iceberg_partition_overwrite_mode";
+ public static final String ICEBERG_PARTITION_OVERWRITE_MODE_DYNAMIC =
"dynamic";
+ public static final String ICEBERG_PARTITION_OVERWRITE_MODE_STATIC =
"static";
+ @VarAttrDef.VarAttr(name = ICEBERG_PARTITION_OVERWRITE_MODE, needForward =
true,
+ checker = "checkIcebergPartitionOverwriteMode", setter =
"setIcebergPartitionOverwriteMode",
+ description = "Scope of INSERT OVERWRITE on an Iceberg table when
no PARTITION clause is given. "
+ + "'static' (default, identical to Spark's default
partitionOverwriteMode=static): the "
+ + "whole table is overwritten, including data written
under an older partition spec. "
+ + "'dynamic' (Hive-compatible and identical to Spark's "
+ + "spark.sql.sources.partitionOverwriteMode=dynamic): only
the partitions the new data "
+ + "lands in are replaced, so data written under an older
partition spec is left untouched.",
+ options = {ICEBERG_PARTITION_OVERWRITE_MODE_STATIC,
ICEBERG_PARTITION_OVERWRITE_MODE_DYNAMIC})
+ public String icebergPartitionOverwriteMode =
ICEBERG_PARTITION_OVERWRITE_MODE_STATIC;
Review Comment:
[P2] Pin the remaining S3 Tables overwrite suite to dynamic mode. With
`enableExternalIcebergTest=true`,
`external_table_p2/iceberg/test_s3tables_glue_insert_overwrite.groovy` still
uses the default mode. Its partitioned `q03` (lines 610-619) overwrites only
`dt=20240321` after seeding `20240320`, `20240321`, and `20240322`, while its
golden expects all three rows (lines 22-24 and 46-48). This new static default
removes the other two partitions, so the suite now fails for both formats. Pin
that suite to `dynamic`, as done for the changed p0 suites, or regenerate its
expectations for static behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
