924060929 commented on code in PR #69133:
URL: https://github.com/apache/doris/pull/69133#discussion_r4282144445
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -2597,6 +2601,20 @@ public Map<String, Action> getForceEagerAggHintMap() {
needForward = true)
public int numFilesInBatchMode = 1024;
+ @VarAttrDef.VarAttr(name = SPLIT_BATCH_SIZE, checker =
"checkPositiveSplitSize", needForward = true,
+ description = "Maximum number of splits in a producer batch.")
+ public int splitBatchSize = 128;
+
+ @VarAttrDef.VarAttr(name = SPLIT_QUEUE_CAPACITY, checker =
"checkPositiveSplitSize", needForward = true,
+ description = "Maximum number of queued split batches per
backend.")
+ public int splitQueueCapacity = 32;
+
+ public void checkPositiveSplitSize(String value) {
Review Comment:
Optional cleanup: reuse the existing `checkFieldValue(variableName, 1,
value)` validation helper for these positive integer settings, as other
settings in this class do. The annotation checker methods can remain thin
wrappers, while parsing, minimum-value checks and errors identifying the actual
variable stay in the common helper. This does not require a new validation
abstraction and is not a merge blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
