github-actions[bot] commented on code in PR #69122:
URL: https://github.com/apache/doris/pull/69122#discussion_r4282302460
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/InPredicate.java:
##########
@@ -136,28 +136,6 @@ public boolean nullable() throws UnboundException {
@Override
public void checkLegalityBeforeTypeCoercion() {
List<Expression> arguments = getArguments();
- if (arguments.get(0).getDataType().isStructType()) {
- // we should check in value list is all struct type
- for (int i = 1; i < arguments.size(); i++) {
- if (!arguments.get(i).getDataType().isStructType() &&
!arguments.get(i).getDataType().isNullType()) {
- throw new AnalysisException("in predicate struct should
compare with struct type list, but got : "
- + arguments.get(i).getDataType().toSql());
- }
- }
- return;
- }
-
- if (arguments.get(0).getDataType().isArrayType()) {
- // we should check in value list is all list type
- for (int i = 1; i < arguments.size(); i++) {
- if (!arguments.get(i).getDataType().isArrayType() &&
!arguments.get(i).getDataType().isNullType()) {
- throw new AnalysisException("in predicate list should
compare with struct type list, but got : "
- + arguments.get(i).getDataType().toSql());
- }
- }
- return;
- }
-
arguments.forEach(c -> {
Review Comment:
[P2] Update the remaining ARRAY IN (NULL) regression
The separate `query_p0/sql_functions/test_in_expr.groovy:167` case still
uses `qt_select` for `select c_array, c_array in (null) from array_in_test`,
where `c_array` is `ARRAY<int>`, and its `.out` expects a NULL result. Removing
the ARRAY exemption makes `processInPredicate` throw the complex-type error
before NULL simplification, so this suite now aborts under the default Nereids
planner. Please convert that case to an expected analysis error and update its
golden too. This is a different suite from the cases named in the earlier
review thread, which this revision has addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
