zddr commented on code in PR #16789:
URL: https://github.com/apache/doris/pull/16789#discussion_r1108148176
##########
fe/fe-core/src/main/java/org/apache/doris/deploy/DeployManager.java:
##########
@@ -148,38 +146,51 @@ public DeployManager(Env env, long intervalMs) {
// Derived Class can override this method to init more private env
variables,
// but must class the parent's init at first.
protected void initEnvVariables(String envElectableFeServiceGroup, String
envObserverFeServiceGroup,
- String envBackendServiceGroup, String envBrokerServiceGroup) {
+ String envBackendServiceGroup, String envBrokerServiceGroup,
String envCnServiceGroup) {
this.electableFeServiceGroup =
Strings.nullToEmpty(System.getenv(envElectableFeServiceGroup));
this.observerFeServiceGroup =
Strings.nullToEmpty(System.getenv(envObserverFeServiceGroup));
this.backendServiceGroup =
Strings.nullToEmpty(System.getenv(envBackendServiceGroup));
this.brokerServiceGroup =
Strings.nullToEmpty(System.getenv(envBrokerServiceGroup));
+ this.cnServiceGroup =
Strings.nullToEmpty(System.getenv(envCnServiceGroup));
- LOG.info("get deploy env: {}, {}, {}, {}", envElectableFeServiceGroup,
envObserverFeServiceGroup,
- envBackendServiceGroup, envBrokerServiceGroup);
+ LOG.info("get deploy env: {}, {}, {}, {}, {}",
envElectableFeServiceGroup, envObserverFeServiceGroup,
+ envBackendServiceGroup, envBrokerServiceGroup,
envCnServiceGroup);
- // electableFeServiceGroup and backendServiceGroup must exist
- if (Strings.isNullOrEmpty(electableFeServiceGroup) ||
Strings.isNullOrEmpty(backendServiceGroup)) {
- LOG.warn("failed to init service group name."
- + " electableFeServiceGroup: {}, backendServiceGroup: {}",
- electableFeServiceGroup, backendServiceGroup);
- System.exit(-1);
Review Comment:
This is to be compatible with only cn running on k8s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
