github-actions[bot] commented on code in PR #69189: URL: https://github.com/apache/doris/pull/69189#discussion_r4292629870
########## regression-test/suites/export_p0/test_result_file_name_padding.groovy: ########## @@ -0,0 +1,111 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +suite("test_result_file_name_padding", "p0,external") { + def bucket = context.config.otherConfigs.get("s3BucketName") + def prefix = "regression/result_file_name_padding/${UUID.randomUUID()}/" + def client = getS3Client() Review Comment: [P2] Handle Azure before constructing the S3 client The regression harness explicitly supports `s3Source="azure"` (`Config.groovy`), but `getS3Client()` always builds an AWS `AmazonS3` client. In that configuration this suite attempts S3-signed listing/deletion against Azure Blob storage (and the default endpoint is only `azure-endpoint`), so it fails before exercising the padding matrix; the `finally` cleanup uses the same failing path. Please guard unsupported providers before creating the client, or use provider-aware listing/deletion and pass the configured provider in the SQL properties. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
