yiguolei commented on code in PR #69070:
URL: https://github.com/apache/doris/pull/69070#discussion_r4293809870
##########
be/src/storage/index/zone_map/zone_map_index.cpp:
##########
@@ -200,49 +202,67 @@ void
TypedZoneMapIndexWriter<Type>::_update_page_zonemap(const ValType& min_valu
_page_zone_map.has_not_null = true;
}
-template <PrimitiveType Type>
-void TypedZoneMapIndexWriter<Type>::_materialize_page_minmax() {
+template <FieldType FT>
+void TypedZoneMapIndexWriter<FT>::_materialize_page_minmax() {
if (!_page_zone_map.has_not_null) {
return;
}
- _page_zone_map.min_value =
doris::Field::create_field_from_olap_value<Type>(_page_min);
- _page_zone_map.max_value =
doris::Field::create_field_from_olap_value<Type>(_page_max);
+ if constexpr (is_string_type(Type)) {
+ _page_zone_map.min_value =
doris::Field::create_field_from_olap_value<Type>(_page_min);
Review Comment:
remove this method create_field_from_olap_value and new string here directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
