abhinav-phi commented on PR #68733: URL: https://github.com/apache/doris/pull/68733#issuecomment-6220159754
@morrySnow both findings are answered in the threads at fe53adf2. the overflow precheck now uses the binary value, and the second one I have been honest about in its thread: that line is the FLOAT to DOUBLE widening owned by sibling pr #68730, so I left it alone here rather than have two of my branches rewriting the same line. same two asks as my other open prs, both outside what I can do as a first time contributor. your approval on this branch was dismissed by the push and needs a fresh +1, and the 9 GitHub Actions runs on fe53adf2 are still at action_required with no jobs. the P0 Regression and cloud_p0 failures from the previous head 0a846402 are the reason this branch re-recorded the float and double integral cast rows in test_cast.out, so a `run p0` and `run cloud_p0` on fe53adf2 would tell us whether that was the right fix or whether there is a real folding difference left. I cannot run a FE plus BE cluster locally to check that myself, so I would rather see the suites report than guess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
