mrhhsg commented on PR #68279:
URL: https://github.com/apache/doris/pull/68279#issuecomment-6252148993
<!-- autopilot-response -->
Re-checked the full review history at HEAD
`725f2f6f97363329234a734bbd06c50abe825315`. No code change was required in this
round.
**Previous inline findings — fixed and resolved:**
- Sparse-accounting overcount in `segment_iterator.cpp`: condition ranges
are again built for the whole segment, and the Bloom filter / zone map /
expression zone map stages charge only rows still set in `_row_bitmap`
(`_count_alive_rows`). `DisjointKeyRangesOnlyCountAliveRows` covers disjoint
key ranges (`{1}`, `{5000}`) with `RowsStatsFiltered == 1`.
- Trailing `DROP TABLE` in `point_lookup_zone_map_profile.groovy`: removed;
the table is only dropped before creation.
**Other top-level comments:** the `hello-stephen` entries are TPC-H / TPC-DS
/ ClickBench benchmark payloads, and the remaining entries are `/review` / `run
buildall` commands and CI failure notices. None contains a code finding.
The current `CHANGES_REQUESTED` decision comes from the `github-actions`
review of 2026-09-20; that reviewer's own review at this HEAD states that no
previously reported blocking finding remains applicable.
**Validation at this HEAD (local):** `SegmentIteratorKeyRangeStatsTest.*`
(10 tests) and `SegmentIteratorExprZonemapTest.*` (21 tests) pass.
Could a maintainer take another look and clear the change request if the
remaining concerns are satisfied?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
