yujun777 commented on code in PR #69268:
URL: https://github.com/apache/doris/pull/69268#discussion_r4311720796
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/types/DecimalV2Type.java:
##########
@@ -249,4 +252,8 @@ public int width() {
return WIDTH;
}
+ @Override
+ public Optional<Expression> defaultValue() {
+ return Optional.of(new DecimalLiteral(this, BigDecimal.ZERO));
Review Comment:
Fixed: zero now carries the type scale before DecimalLiteral validates it
(`BigDecimal.ZERO.setScale(getScale())`), and the same fix is applied to
DecimalV3Type. IvmUtilTest now covers DECIMAL(9,9) for both V2 and V3.
Also reversed the regression join so the sequence-bearing table is the right
child; a delta on the left dimension then makes it the pre-snapshot side, so
the suite exercises the temporal placeholder end to end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]