github-actions[bot] commented on code in PR #69338:
URL: https://github.com/apache/doris/pull/69338#discussion_r4323545185
##########
be/src/exec/sink/writer/iceberg/viceberg_partition_writer.cpp:
##########
@@ -97,34 +98,17 @@ Status VIcebergPartitionWriter::open(RuntimeState* state,
RuntimeProfile* profil
switch (_file_format_type) {
case TFileFormatType::FORMAT_PARQUET: {
- TParquetCompressionType::type parquet_compression_type;
- switch (_compress_type) {
- case TFileCompressType::PLAIN: {
- parquet_compression_type = TParquetCompressionType::UNCOMPRESSED;
+ auto parquet_compression_type =
+
ParquetBuildHelper::to_parquet_compression_type(_compress_type);
+ if (!parquet_compression_type.has_value()) {
+ // The target file is already created, so let the shared cleanup
below remove it
+ // instead of returning early.
+ open_status = parquet_compression_type.error();
Review Comment:
[P1] Complete the codec error-handling block before using open_status
`open_status` is not declared in `open()`, `VIcebergPartitionWriter`, or its
base class, so this translation unit fails to compile in every BE build,
regardless of the selected codec. The new `break` also exits the switch
directly into the end of this `Status`-returning function: there is no shared
cleanup/return block below it. Complete the intended cleanup and status return,
or propagate the helper error through a valid return path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
