morningman opened a new pull request, #4414:
URL: https://github.com/apache/doris-website/pull/4414

   ## Why
   
   Manual runs of the Korean translation workflow defaulted to `dry-run`, while 
the Japanese workflow defaults to `generate`. The Korean default dates from 
when Korean generation was manual-only. Korean runs have been scheduled since 
#4409, so both workflows now use the same default: a manual run started without 
changing the mode generates, like a scheduled run.
   
   ## What changed
   
   - `korean-translation.yml`: the manual `mode` input defaults to `generate`. 
`dry-run` and `validate` can still be selected. Scheduled runs are unchanged.
   - `translation-workflows.test.cjs`: the contract test now requires both 
workflows to default to `generate` and checks that the default passes the 
generation gate. A run with `dry-run` selected still never reaches the 
generator.
   - `translations/README.md`: updated the two sentences that described the 
Korean `dry-run` default.
   
   ## Effect
   
   A Korean run started from the Actions page without changing the mode now 
generates a batch when pages are pending. It calls the model and opens a 
labeled PR for review, as a Japanese manual run does. Nothing is merged 
automatically. For a read-only check, select `dry-run` (or pass `-f 
mode=dry-run`).
   
   The lock and triggers are unchanged, and a run already in progress keeps the 
workflow definition it started with, so this can be merged at any time.
   
   ## Verification
   
   - All 21 translation test suites in Build Check pass on Node 20.20.2 (193 
tests), and so does the publish suite.
   - Restoring the `dry-run` default makes two contract tests fail.
   - actionlint 1.7.12 reports nothing new. The two remaining findings, the 
`queue` concurrency key and `actions/setup-python@v4`, also exist on master.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to