jacktengg commented on code in PR #69271:
URL: https://github.com/apache/doris/pull/69271#discussion_r4333612987
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/util/TypeCoercionUtils.java:
##########
@@ -1154,17 +1148,14 @@ private static Optional<DataType>
getCommonDataTypeWithDateTimeV2Type(
return Optional.empty();
}
- /** Choose TIMESTAMP_NS for compatible DATETIME-family coercion. */
+ /** Choose TIMESTAMP_NS for compatible date-like coercion. */
private static Optional<DataType>
getCommonDataTypeWithTimeStampNsType(DataType otherType) {
if (otherType instanceof TimeStampNsType) {
return Optional.of(TimeStampNsType.INSTANCE);
}
- if (isTimeStampNsCompatibleDateTimeType(otherType)) {
+ if (isOtherDateLikeType(otherType)) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
