morningman opened a new pull request, #69373:
URL: https://github.com/apache/doris/pull/69373
### What problem does this PR solve?
Issue Number: None
Related PR: #69311, #63639, #69268
Problem Summary:
**In short.** #69311 renamed row binlog to changelog: a changelog table is
now created with `"changelog.enable" = "true"`, gated by
`enable_feature_changelog`, and DDL that still sets `"binlog.format"` or
`"binlog.need_historical_value"` fails. Two tests that reached master a few
hours before #69311 still create their tables the old way, so master fails them
since #69311 was merged. This PR switches both to the new properties.
**The problem.** Each test was added by a PR that was green on its own;
#69311's CI ran on a master without them, so neither side saw the conflict.
| Test | Added by | On master now |
|---|---|---|
| FE UT
`RelationImpliedPredicateTest.testIvmOutputPredicatesSkipHiddenColumns` (both
parameters) | #63639 | `DdlException: Property binlog.format is no longer
supported, use "changelog.enable" = "true" to enable changelog, or remove it
for CCR binlog` when it creates its IVM base table |
| Regression `mtmv_p0/ivm/test_ivm_datetime_sequence` | #69268 | the same
error on its first CREATE TABLE |
Every PR's FE UT run includes `RelationImpliedPredicateTest`, so it fails
for all PRs until this is merged.
**How this PR fixes it.** The same change #69311 made to the other IVM tests:
- `RelationImpliedPredicateTest`: the base table uses `'changelog.enable' =
'true'` instead of `'binlog.enable' = 'true', 'binlog.format' = 'ROW'`, and the
test switches `Config.enable_feature_changelog` on (and restores it) instead of
`enable_feature_binlog`, which no longer gates changelog tables.
- `test_ivm_datetime_sequence`: both tables use `"changelog.enable" =
"true", "changelog.need_historical_value" = "true"` instead of `"binlog.enable"
= "true", "binlog.format" = "ROW", "binlog.need_historical_value" = "true"`.
Its queries and `.out` do not change.
### Release note
None
### Check List (For Author)
- Test: Unit Test, Regression test
- FE UT: `RelationImpliedPredicateTest` passes; on master both
parameters of `testIvmOutputPredicatesSkipHiddenColumns` fail with the error
above.
- Regression: `mtmv_p0/ivm/test_ivm_datetime_sequence` passes against
its existing `.out` on a local cluster.
- Behavior changed: No
- Does this need documentation: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
