shuke987 opened a new pull request, #69377: URL: https://github.com/apache/doris/pull/69377
### What problem does this PR solve? Issue Number: None Related PR: #67649 When an automated review reconfirms an existing blocker whose heading starts with `**[P1] ...**` or `**[P1]** ...`, `submit_review.py` rejects the historical comment before posting the final review. This caused [run 39532829872](https://github.com/apache/doris/actions/runs/39532829872) and [run 39535990055](https://github.com/apache/doris/actions/runs/39535990055) to finish without delivering a review. Normalize the leading bold priority markup only when counting explicitly reconfirmed existing comments. New findings retain their strict format. Existing P0/P1 findings still request changes without duplicate inline comments, and existing P2/P3 findings remain invalid as blockers. ### Release note None ### Check List (For Author) - Test: - [x] Unit Test: `test_submit_review.py` — 40 passed; `test_run_review_with_resume.py` — 78 passed, 3 Linux-only tests skipped on macOS; `test_resolve_code_review_status.py` — 20 passed. - [x] Manual test: the new bold-comment cases fail against the original implementation. `git diff --check` passes. - Coverage includes P0/P1 counts, exact readback, repeated submission without reposting, rejection of P2/P3 and malformed or reply comments, and strict validation of new findings. GitHub API calls are mocked. - Behavior changed: - [x] Yes. Existing review comments with bold priority headings can be reconfirmed and delivered. - Does this need documentation? - [x] No. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
