suxiaogang223 opened a new pull request, #69378:
URL: https://github.com/apache/doris/pull/69378

   ### What problem does this PR solve?
   
   Issue Number: N/A
   
   Related PR: None
   
   Problem Summary:
   Legacy ClickHouse JDBC drivers report versions such as `clickhouse-jdbc 
0.3.2-patch11 (revision: 27f8951)`. The retained FE client parses the artifact 
prefix as an integer and fails initialization. The connector client treats the 
same parse failure as an unknown/new driver, which can select the wrong 
metadata mode.
   
   Remove the known artifact prefix before the existing major/minor comparison 
in both clients. Versions below 0.5 continue to use legacy metadata mode; the 
existing behavior for unrelated unknown or invalid strings is preserved.
   
   ### Release note
   
   Fix recognition of ClickHouse JDBC versions that include the 
`clickhouse-jdbc` artifact prefix.
   
   ### Check List (For Author)
   
   - Test: targeted FE UT through `run-fe-ut.sh` with the JDBC connector 
included: 11 tests passed (6 connector, 5 FE client). Checkstyle 9.3 with the 
repository configuration passed for all four changed files; `git diff --check` 
passed.
   - Tests cover the original 0.3.2-patch11 string, 0.4/0.5/1.0 boundaries, and 
legacy metadata selection even when catalog support is advertised.
   - No external ClickHouse server/driver integration test was run.
   - Behavior changed: Yes. Prefixed legacy driver versions are recognized as 
legacy rather than failing or being classified as new.
   - Does this need documentation: No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to