csun5285 commented on code in PR #69070:
URL: https://github.com/apache/doris/pull/69070#discussion_r4334578027
##########
be/src/storage/index/index_writer.h:
##########
@@ -50,10 +50,14 @@ class IndexColumnWriter {
IndexColumnWriter() = default;
virtual ~IndexColumnWriter() = default;
- virtual Status add_values(const std::string name, const void* values,
size_t count) = 0;
-
- virtual Status add_array_values(size_t field_size, const void* value_ptr,
- const uint8_t* null_map, const uint8_t*
offsets_ptr,
+ // Aligned storage values: fixed-width cells or Slice descriptors. The
writer's
+ // field type determines the layout; count is the number of values.
+ virtual Status add_values(const std::string name, const uint8_t* values,
size_t count) = 0;
Review Comment:
[P1] Adapt the new master test callers to the byte-view API
After rebasing onto master `cca22317162`, `./run-be-ut.sh --run -j 128`
fails to compile `be/test/storage/index/index_disk_usage_test.cpp`:
`feed_text()` at line 263 and `feed_many_text()` at line 345 pass `Slice*`, and
`feed_numbers()` at line 268 passes `int32_t*`. These fixtures were added by
#67977 and still rely on the old `const void*` parameter; neither pointer
implicitly converts to the new `const uint8_t*`. Adapt all three callers to the
explicit storage byte view used by the other migrated fixtures so the rebased
BE UT target can build. This is a rebase integration failure; the published PR
head has not yet been updated to the local rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
