github-actions[bot] commented on code in PR #63528: URL: https://github.com/apache/doris/pull/63528#discussion_r4335387848
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ComplexEquals.java: ########## @@ -0,0 +1,71 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.functions.scalar; + +import org.apache.doris.catalog.FunctionSignature; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.functions.AlwaysNotNullable; +import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature; +import org.apache.doris.nereids.trees.expressions.shape.BinaryExpression; +import org.apache.doris.nereids.types.BooleanType; +import org.apache.doris.nereids.types.coercion.AnyDataType; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableList; + +import java.util.List; + +/** + * ScalarFunction 'complex_equals'. Compares two values of the same complex type recursively. + * + * <p>The comparison is NULL safe: two NULL values, including a NULL nested field, are equal, while + * a NULL and a non-NULL value are not. This is the equality the load mapping needs for a nested + * value; the caller keeps the SQL three-valued behavior of a top level NULL search itself. + */ +public class ComplexEquals extends ScalarFunction + implements BinaryExpression, ExplicitlyCastableSignature, AlwaysNotNullable { + + public static final List<FunctionSignature> SIGNATURES = ImmutableList.of( + FunctionSignature.ret(BooleanType.INSTANCE) + .args(new AnyDataType(0), new AnyDataType(0))); Review Comment: [P2] Restrict the public comparator to supported leaf types This is registered as a normal SQL builtin, so the ANY signature also accepts `complex_equals(to_bitmap(1), to_bitmap(1))` and BITMAP leaves inside `named_struct`. Both arguments bind to the same type, but `FunctionComplexEquals::equals_at` calls `compare_at`; `ColumnBitmap` (also HLL/QUANTILE_STATE) implements that method only under `BE_TEST`, so production throws `NOT_IMPLEMENTED_ERROR` instead of evaluating the call. The load planner's capability checks do not protect direct SQL calls. Add a recursive argument-legality check or make this helper internal, and cover rejection in SQL tests since BE unit builds mask the missing implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
