Gabriel39 commented on code in PR #69346:
URL: https://github.com/apache/doris/pull/69346#discussion_r4336129364


##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/FullTextSearchTableValuedFunction.java:
##########
@@ -55,11 +56,28 @@ public FullTextSearchTableValuedFunction(Map<String, 
String> properties)
         super(prepare(properties));
     }
 
-    private static PreparedSearch prepare(Map<String, String> properties)
+    /** Builds a search from the metadata snapshot already bound to the source 
scan. */
+    public static FullTextSearchTableValuedFunction forScan(Map<String, 
String> properties,
+            LanceExternalTable table, LanceTableMetadata metadata, byte[] 
substraitFilter)
             throws AnalysisException {
+        return new FullTextSearchTableValuedFunction(prepare(properties, 
table, metadata), substraitFilter);

Review Comment:
   Fixed in 16f8c096e7. The bound-scan factories preserve physical column names 
and MATCH query text verbatim, including whitespace-only raw-tokenizer queries. 
Explicit TVF property normalization is unchanged. Added regressions for padded 
query literals and coexisting padded/unpadded vector and text columns; both 
failed before the fix and now pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to