github-actions[bot] commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4343778212
##########
be/src/exprs/function/geo/functions_geo.cpp:
##########
@@ -382,16 +798,25 @@ struct StAreaSquareMeters {
auto return_type = block.get_data_type(result);
auto col =
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ const auto& input_type = block.get_data_type(arguments[0]);
+ RETURN_IF_ERROR(validate_geography_semantics(input_type, NAME));
Review Comment:
[P2] Register typed area signatures in the FE
`ST_Area_Square_Meters(geog)` on an Iceberg table with `geog GEOGRAPHY`
fails during FE binding: `Project[st_area_square_meters(geog)] ->
IcebergScan[geog]`. `StAreaSquareMeters` and `StAreaSquareKm` still expose only
VARCHAR signatures, and `ExplicitlyCastableSignature` cannot cast Geography to
VARCHAR because `CheckCast` has no spatial entry. Consequently this new raw-WKB
area implementation is unreachable from SQL; the added direct-BE area test
bypasses the failure. Add metadata-preserving spatial signatures, as for
`StLength`, and SQL coverage for both area functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
