github-actions[bot] commented on code in PR #69425: URL: https://github.com/apache/doris/pull/69425#discussion_r4344717092
########## regression-test/suites/nereids_rules_p0/agg_strategy/bucketed_hash_agg_num_buckets.groovy: ########## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +suite("bucketed_hash_agg_num_buckets") { + sql "set enable_sql_cache=false" + sql "set enable_bucketed_hash_agg=false" + sql "set be_number_for_test=1" + sql "set agg_phase=1" + sql "set bucketed_agg_min_input_rows=0" + sql "set bucketed_agg_max_group_keys=0" + sql "set bucketed_agg_high_card_threshold=1.0" Review Comment: [P2] Disable spill before requiring the bucketed plan The p0 FE configuration enables fuzzy sessions, and `SessionVariable.initFuzzyModeVariables()` randomly turns on `enable_spill` and `enable_force_spill`. `AggregateUtils.isBucketedHashAggEnabled()` returns false when either is enabled, so this suite's first `contains "VBUCKETED AGGREGATE"` fails for those normal CI sessions and the bucket-count matrix never runs. Set both flags to false in the setup, as the existing `bucketed_hash_agg` suite does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
