Gabriel39 commented on code in PR #69082:
URL: https://github.com/apache/doris/pull/69082#discussion_r4345273640
##########
be/src/io/cache/cached_remote_file_reader.cpp:
##########
@@ -465,7 +465,7 @@ void launch_s3_race(std::shared_ptr<RaceState> race, size_t
empty_start, size_t
// Do NOT capture io_ctx: it points into the caller's stack/iterator which
may be
// destroyed when the query is cancelled before this background task runs.
The S3
// leg of the race is a best-effort background task whose result is
discarded if the
- // peer wins; passing nullptr is safe because S3FileReader::read_at_impl
ignores it.
+ // peer wins; passing nullptr is safe because
ObjStorageFileReader::read_at_impl ignores it.
auto do_s3_read = [race, empty_start, span_size, remote_reader, owner]() {
Review Comment:
这里的s3之类的变量名都换一下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
