CalvinKirs commented on PR #69455:
URL: https://github.com/apache/doris/pull/69455#issuecomment-6336870751
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69455
commit: 0844130389b4caf3aae5409cb5bc80e96da56d4d
base: 5e3ed84abb0d467276f8481de72a1a037f22810f
reviewed_at: 2026-10-22T16:58+08:00
reviewer: CalvinKirs
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/tablefunction/HttpTableValuedFunction.java:84`
— APPROVE for the requested FE HEAD hook integration: direct HTTP/HTTPS and
each HF-expanded file URL enter the same scope. Default no-op policy, HF
tree/list API requests and BE reads are unchanged; no full SSRF-protection
claim is made.
-
`fe/fe-common/src/main/java/org/apache/doris/cloud/security/UrlSecurityChecker.java:39`
and
`fe/fe-common/src/main/java/org/apache/doris/cloud/security/UrlSecurityChecker.java:70`
— Existing follow-up: stop is looked up with a String parameter but invoked
with no arguments, so SDK cleanup is not established by calling this adapter.
Both lines are unchanged in the reviewed base; this was not counted as a newly
introduced finding.
-
`fe/fe-core/src/test/java/org/apache/doris/tablefunction/HttpTableValuedFunctionTest.java:70`
— The main reviewer and two independent reviewers covered both changed files;
no builds or tests were rerun during the read-only review. Prior execution
records show all 5 new cases passing; existing HFUtilsTest had 13 passes and 1
network-unreachable error, so the combined Maven run was not green. Actual SDK
behavior and a running cluster were not verified.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of
`.github/workflows/code-review-runner.yml`). This is not a CI status
check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
