eldenmoon opened a new pull request, #69459:
URL: https://github.com/apache/doris/pull/69459
### What problem does this PR solve?
Issue Number: close # (none)
Problem Summary:
`variant_p0/schema_change/test_double_write_when_schema_change` and its `v2`
sibling are flaky:
`qt_two_phase_off` / `qt_two_phase_on` intermittently fail with
```
Check tag 'two_phase_off' failed, line 6, TINYTEXT result mismatch.
Expect cell is: 123111
But real is : 123111.0
```
or the opposite direction (`expect 123111.0, real 123111`).
The suite inserts the string literal `"123111.0"` into `change_column` while
the column is being
altered from `double` to `text`, and then compares the whole row:
* rows written while the column is still `double` are stored as `123111.0`
and are converted by
the `double -> text` cast, which prints `123111`;
* rows written after the column has become `text` keep the literal
`123111.0`.
How many rows fall into each window depends on the schema change timing (the
test inserts one row
per loop iteration while `SHOW ALTER TABLE COLUMN` reports `RUNNING`), so no
single expected file
can match reliably.
This is a test issue rather than a product issue: both values are correct
for the phase in which
the row was written.
### What is changed?
Use an integer valued literal (`"123111"`) so the `double -> text`
conversion and the direct
`text` write both produce `123111`, and update the
`variant_p0/schema_change` expected file
accordingly. The `v2` expected file already contains `123111` only.
`branch-4.1` and `branch-4.2` carry the same case and would need the same
pick.
### Release note
None
### Check List (For Author)
- Test
- [x] Regression test
- Behavior changed:
- [x] No.
- Does this need documentation?
- [x] No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
