sollhui opened a new pull request, #69462:
URL: https://github.com/apache/doris/pull/69462
### What problem does this PR solve?
Issue Number: N/A
Problem Summary:
Altering a Kafka Routine Load job logs the complete data source properties
object at INFO level. Its inherited `toString()` includes the original
properties map, so Kafka passwords and authentication configuration can appear
in FE logs. Edit-log replay uses the same logging path.
Log the job ID and only the changed job/data source property keys. Keep
property values intact for runtime configuration and persistence, and preserve
support for job-only alterations and absent original property maps.
### Release note
Kafka Routine Load property changes no longer write property values to FE
INFO logs.
### Check List (For Author)
- Test
- [x] Unit Test (added; local execution blocked as described below)
- [ ] Regression test
- [ ] Manual test
- [ ] No need to test or manual test.
Added log-capture coverage to `KafkaRoutineLoadJobTest` for normal ALTER
and edit-log replay, synthetic SASL/SSL/OAuth values and an ordinary custom
value, preserved runtime values, and null/empty data source properties.
Validation:
- Passed: `mvn -o checkstyle:check -pl fe-core` (0 violations).
- Passed: `git diff --check`.
- Attempted: `bash run-fe-ut.sh --run
'org.apache.doris.load.routineload.KafkaRoutineLoadJobTest#testModifyAndReplayPropertiesDoNotLogValues+testModifyJobPropertiesWithoutDataSource'`.
The local JDK 17 installation is incomplete (`lib/modules` is missing; `java
-version` reports `Failed setting boot class path`), so the script exits during
its Java environment check before compiling or executing tests. The unit tests
still need CI execution.
- Behavior changed:
- [ ] No.
- [x] Yes. The INFO event retains the job ID and changed property names
and omits all property values. Job configuration and persistence are unchanged.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
