github-actions[bot] commented on code in PR #69028:
URL: https://github.com/apache/doris/pull/69028#discussion_r4355718537
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java:
##########
@@ -545,7 +554,7 @@ public void afterCommitTxnResp(CommitTxnResponse
commitTxnResponse, List<TabletC
}
}
Env env = Env.getCurrentEnv();
- env.getAnalysisManager().updateUpdatedRows(updatedRows);
+ env.getAnalysisManager().updateUpdatedRows(updatedRows, dbId,
reportedPartitions);
Review Comment:
[P2] Supply row counters for the other cloud load producers
On a cloud DUP table, `TRUNCATE TABLE t; BEGIN; INSERT INTO t SELECT number
FROM numbers("number"="3"); COMMIT;` still leaves `Project(*) -> OlapScan(t)`
estimated at 1 before tablet statistics arrive:
`commitTransactionWithSubTxns()` puts base-tablet IDs only in `SubTxnInfo`, but
meta-service `commit_txn_with_sub_txn()` passes the empty top-level
`request->base_tablet_ids()` to `calc_table_stats()`. Its response therefore
has no `updated_row_count`, so the new call here receives an empty
`updatedRows` map and creates no record. Non-MoW/non-TSO BE-direct stream loads
with `enable_stream_load_commit_txn_on_be=true` have the same gap because
`CloudMetaMgr::commit_txn()` supplies no base-tablet IDs either. These paths
retain the original symptom despite the new cloud recreation path. Carry the
required tablet IDs/counters through both producers and add coverage using
their actual commit responses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
