github-actions[bot] commented on code in PR #69391:
URL: https://github.com/apache/doris/pull/69391#discussion_r4356220741
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/kafka/KafkaDataSourceProperties.java:
##########
@@ -253,10 +254,33 @@ private void analyzeCustomProperties() throws
AnalysisException {
}
}
+ validateCustomProperties(customKafkaProperties);
Review Comment:
[P2] Migrate the existing positive SSL test to managed file references
This new call makes `KafkaAwsMskIamAuthTest.testSslConfigWithoutSasl()`
fail: that existing JUnit test supplies `/path/to/ca-cert`,
`/path/to/client-cert` and `/path/to/client-key`, then calls `props.analyze()`
expecting success. The managed-file check now throws `AnalysisException` before
its assertions, so the normal FE unit suite cannot pass. Update that positive
fixture to use `FILE:<name>` values alongside this policy change; the new
validation tests can retain coverage of raw-path rejection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
