deardeng opened a new pull request, #69532:
URL: https://github.com/apache/doris/pull/69532
Problem Summary: When a BE receives its cluster token or a new
authentication token, heartbeat INFO logs include the credential values. A
cluster-token mismatch also includes both tokens in the error response, which
can propagate to FE logs. Keep the heartbeat event messages and invalid-token
error while removing credential values. Add a unit test covering
initialization, repeated heartbeats, successive authentication-token updates,
and token mismatch, including checks that logs and error responses do not
contain the credentials.
### Release note
Prevent cluster and authentication tokens from appearing in heartbeat logs
and token-mismatch errors.
### Check List (For Author)
- Test: Unit Test - 9 selected BE ASAN tests passed via run-be-ut.sh,
covering HeartbeatServerTest.*, HttpAuthTest.*, and
ChangelogTtlTest.HeartbeatFencesClusterMasterAndEpoch. Set
GLIBC_COMPATIBILITY=OFF for the local test run to avoid duplicate symbols from
the LDB toolchain. clang-format v16, build hygiene, clang-tidy, and git diff
--check passed.
- Behavior changed: Yes, heartbeat diagnostics no longer contain token
values.
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
