github-actions[bot] commented on code in PR #69545:
URL: https://github.com/apache/doris/pull/69545#discussion_r4360080573
##########
fe/fe-connector/fe-connector-paimon/src/main/java/org/apache/doris/connector/paimon/PaimonScanParams.java:
##########
@@ -103,6 +105,13 @@ public final class PaimonScanParams {
private static final Set<String> INHERITED_READ_STATE_KEYS =
buildInheritedReadStateKeys();
+ private static final Set<String> SCHEMA_INDEPENDENT_READ_KEYS =
ImmutableSet.<String>builder()
+ .addAll(INHERITED_READ_STATE_KEYS)
+ .add(CoreOptions.BRANCH.key())
+ .add(CoreOptions.SCAN_PRIMARY_BRANCH.key())
+ .add(CoreOptions.SCAN_FALLBACK_BRANCH.key())
+ .build();
Review Comment:
[P2] Preserve current reader tuning when restoring historical fields
This new preserve set omits schema-independent reader options. Consider a
Paimon table that commits snapshot 1 with `read.batch-size=131072` (valid in
the SDK), then changes that physical option to `1024`. With no catalog or
relation batch override, `FOR VERSION AS OF 1` calls `restoreBoundSchema`,
which starts with the old `131072`; current `1024` equals the current persisted
value, so the delta loop does not copy it, and this set does not preserve it
either. Final `PaimonReaderOptions.validateEffectiveTable` therefore rejects
the historical query against Doris's maximum of `65536`, while the previous SDK
copy kept `1024` and succeeded. This is a reader-tuning omission in the new
set, separate from the startup-selector conflict in existing thread 4359737386.
Retain effective current reader tuning, including removed keys, while restoring
historical field-dependent options, and add a regression for a repaired
physical setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
