morningman commented on PR #69525: URL: https://github.com/apache/doris/pull/69525#issuecomment-6365408825
Addressed the review in a2ea9eb50f0: - [BDB write failures](https://github.com/apache/doris/pull/69525#discussion_r4358373884): the exits that `BDBJEJournal` takes on its own on the write path now go through `EditLog.exitOnWriteFailure`, so the shutdown hook sees them. This includes the roll check, which the comment did not list. New test: `BDBJEJournalTest#testWriteFailuresExitThroughEditLog`. - [Failure while the hook waits](https://github.com/apache/doris/pull/69525#discussion_r4358373898): `gracefulShutdown` checks the failure on every round of its wait instead of only on entry. New test: `DorisFETest#testGracefulShutdownStopsWaitingWhenEditLogWriteFailsWhileWaiting`. The PR description is updated: item 3, the results table, the class list and the test notes. The claim about the lock-free writers of `TransactionState` is narrowed to the publish and finish paths that this PR covers. The FE unit tests listed in the description pass (118 tests, 0 failures), and checkstyle reports no violations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
