This is an automated email from the ASF dual-hosted git repository.
gavinchou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 0e6ab395d26 [fix](security) Stop logging sensitive FE RPC requests
(#69472)
0e6ab395d26 is described below
commit 0e6ab395d26d82698fb382f945d7a3e7ad993bba
Author: Gavin Chou <[email protected]>
AuthorDate: Fri Oct 23 18:10:17 2026 +0800
[fix](security) Stop logging sensitive FE RPC requests (#69472)
### What problem does this PR solve?
Several binlog, snapshot, and master-token RPC handlers log complete
Thrift requests at DEBUG or TRACE level. These requests can contain
password, passwd, or token credentials.
Remove the full-request logs from getBinlog, getBinlogLag, lockBinlog,
getSnapshot, restoreSnapshot, and getMasterToken. Existing non-sensitive
snapshot summary logs remain unchanged.
### Release note
Prevent authentication credentials from being written to FE logs by
removing verbose request logging from the affected RPCs.
---
.../java/org/apache/doris/service/FrontendServiceImpl.java | 14 --------------
1 file changed, 14 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
b/fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
index b31d1daaa2b..50873fb01d6 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
@@ -4027,9 +4027,6 @@ public class FrontendServiceImpl implements
FrontendService.Iface {
public TGetBinlogResult getBinlog(TGetBinlogRequest request) throws
TException {
String clientAddr = getClientAddrAsString();
- if (LOG.isDebugEnabled()) {
- LOG.debug("receive get binlog request: {}", request);
- }
TGetBinlogResult result = new TGetBinlogResult();
TStatus status = new TStatus(TStatusCode.OK);
@@ -4146,7 +4143,6 @@ public class FrontendServiceImpl implements
FrontendService.Iface {
// getSnapshot
public TGetSnapshotResult getSnapshot(TGetSnapshotRequest request) throws
TException {
String clientAddr = getClientAddrAsString();
- LOG.trace("receive get snapshot info request: {}", request);
TGetSnapshotResult result = new TGetSnapshotResult();
TStatus status = checkMaster();
@@ -4260,7 +4256,6 @@ public class FrontendServiceImpl implements
FrontendService.Iface {
// Restore Snapshot
public TRestoreSnapshotResult restoreSnapshot(TRestoreSnapshotRequest
request) throws TException {
String clientAddr = getClientAddrAsString();
- LOG.trace("receive restore snapshot info request: {}", request);
TRestoreSnapshotResult result = new TRestoreSnapshotResult();
TStatus status = checkMaster();
@@ -4415,9 +4410,6 @@ public class FrontendServiceImpl implements
FrontendService.Iface {
public TGetMasterTokenResult getMasterToken(TGetMasterTokenRequest
request) throws TException {
String clientAddr = getClientAddrAsString();
- if (LOG.isDebugEnabled()) {
- LOG.debug("receive get master token request: {}", request);
- }
TGetMasterTokenResult result = new TGetMasterTokenResult();
TStatus status = checkMaster();
@@ -4445,9 +4437,6 @@ public class FrontendServiceImpl implements
FrontendService.Iface {
// getBinlogLag
public TGetBinlogLagResult getBinlogLag(TGetBinlogRequest request) throws
TException {
String clientAddr = getClientAddrAsString();
- if (LOG.isDebugEnabled()) {
- LOG.debug("receive get binlog lag request: {}", request);
- }
TGetBinlogLagResult result = new TGetBinlogLagResult();
TStatus status = checkMaster();
@@ -4547,9 +4536,6 @@ public class FrontendServiceImpl implements
FrontendService.Iface {
public TLockBinlogResult lockBinlog(TLockBinlogRequest request) throws
TException {
String clientAddr = getClientAddrAsString();
- if (LOG.isDebugEnabled()) {
- LOG.debug("receive lock binlog request: {}", request);
- }
TLockBinlogResult result = new TLockBinlogResult();
TStatus status = checkMaster();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
