hello-stephen opened a new pull request, #69572:
URL: https://github.com/apache/doris/pull/69572

   ### What problem does this PR solve?
   
   `txn_insert_with_schema_change` declares `schemaChange(sql, tName, 
job_state)`, but both replica-change worker calls provide only `(sql, null)`. 
Groovy throws `MissingMethodException` before entering the closure or its error 
handling. Add the third `null` at those two call sites so the existing DDL 
executes without polling a schema-change job inside the closure.
   
   Only those two arguments change. DDL text, waits, latches, all assertions, 
and later explicit job-state checks remain byte-for-byte unchanged. Cloud 
replica applicability and global worker-error attribution are outside this 
change.
   
   ### Validation
   
   - Both complete original and patched suites compile and are discovered 
through an actual regression framework `SuiteScript`/`ScriptContext` (Groovy 
4.0.19, JDK 17).
   - Exact source closure and call expressions: both original two-argument 
calls raise `MissingMethodException` with zero connection/DDL calls; both 
patched calls execute the same DDL once, skip polling for null job state, and 
release the insert latch.
   - Positive control with `WAITING_TXN` invokes polling; injected DDL failure 
is still recorded by the closure and leaves the insert latch unreleased. Eight 
local gates passed.
   - Independent review confirms the file differs only by the two added null 
arguments. `git diff --check` passed.
   
   Limits: JDBC is mocked; no Doris database runtime was executed. The existing 
dependency framework JAR has an unknown source SHA, so compile/discovery is not 
a full target-framework build or proof of cloud replica behavior. Runtime with 
a fix-containing case artifact remains pending.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test: Complete-case compile/discovery and exact-source closure validation 
with mocked JDBC.
   - Behavior changed: Yes, replica-change workers enter the existing closure 
instead of failing argument dispatch.
   - Does this need documentation: No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to