morningman commented on PR #69571: URL: https://github.com/apache/doris/pull/69571#issuecomment-6385140803
Addressed the first review round in `65a1682d334`. Per finding: - 4366822772 (P2, deletion vectors of data files at external paths): fixed. On a table with `index-file-in-data-file-dir = true`, every deletion vector of a split with a non-NULL binary partition value must exist, whether or not its data file has an external path; a missing one fails planning and names the deletion vector file. A BE-side change that makes a missing Paimon deletion vector an error instead of a skipped range is tracked separately. - 4366822776 (P2, the schema ID does not prove how a file was named): fixed. A file whose schema uses legacy names fails planning only if it is also missing at its planned path, so a file written with a dynamic `partition.legacy-name = false` stays readable once the table uses those names. The inverse, a dynamic `true` over a `false` schema, is not covered, as on master and branch-4.2. Three new tests in `PaimonScanPlanProviderTest`; the 851 tests of fe-connector-paimon run without failures (1 skipped, as before). The PR description is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
