OIiveirra commented on code in PR #69527:
URL: https://github.com/apache/doris/pull/69527#discussion_r4367889766
##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/S3TableValuedFunction.java:
##########
@@ -63,6 +64,11 @@ public S3TableValuedFunction(Map<String, String> properties,
List<TBrokerFileSta
} catch (UserException e) {
throw new RuntimeException(e);
}
+ // Validate the final URI, including when BrokerProperties passes it
through unchanged.
+ // A local dataset must not bypass the LOCAL switch, privileges or BE
secure directory.
+ if (isLanceFormat() && !LanceTvfStoragePolicy.isRemoteUri(filePath)) {
Review Comment:
The retained broker-to-Hadoop variant is now covered: admission uses the
actual requested/range file type as well as the listing adapter class. A broker
HDFS request with RawLocalFileSystem rejects before listing; supplied/returned
HDFS and local paths are checked in both constructor branches. Declared CSV
schema cannot bypass these data checks. A remote broker/Hadoop control and
existing Lance SDK URI controls pass. The separate inherited
BE-default-provider limitation remains explicitly unresolved in the PR
description.
Follow-up commit: f77cbb4a48a2327686c6494e2d382846b7fbb46c. 73 selected FE
tests passed with fresh XML, no failures/errors/skips and unchanged inputs;
targeted Checkstyle passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
