OIiveirra commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4368313327
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/MinMap.java:
##########
@@ -53,6 +53,7 @@ protected DataType returnValueType(DataType valueType) {
@Override
public void checkLegalityBeforeTypeCoercion() {
+ super.checkLegalityBeforeTypeCoercion();
Review Comment:
Fixed in a9feb78e3ac. MIN_MAP/MAX_MAP now reject spatial leaves recursively,
including aggregate-state paths. MAP_AGG/MAP_AGG_V2 and COUNT_MAP retain
ordinary-key spatial-value support. Added both-kind, nullable/nested and state
coverage; targeted FE tests and the Iceberg regression passed.
##########
be/src/format/parquet/schema_desc.cpp:
##########
@@ -268,7 +269,22 @@ std::pair<DataTypePtr, bool>
FieldDescriptor::convert_to_doris_type(
tparquet::LogicalType logicalType, bool nullable) {
std::pair<DataTypePtr, bool> ans = {std::make_shared<DataTypeNothing>(),
false};
bool& is_type_compatibility = ans.second;
- if (logicalType.__isset.STRING) {
+ if (logicalType.__isset.GEOMETRY) {
+ const std::string crs =
+ logicalType.GEOMETRY.__isset.crs ? logicalType.GEOMETRY.crs :
"OGC:CRS84";
+ // OPTIONAL spatial fields must retain their definition-level
threshold for COUNT.
+ auto spatial_type = std::make_shared<DataTypeSpatial>(TYPE_GEOMETRY,
crs);
Review Comment:
Fixed in a9feb78e3ac. Explicit VARBINARY table targets preserve WKB bytes
and NULLs for valid spatial-annotated Parquet through the v1 converter and v2
EvolutionCast. Native spatial inference and ordinary SQL CAST remain unchanged.
Added both-kind converter/evolution tests and Array/Map/Struct leaf
materialization coverage; targeted BE tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
