github-actions[bot] commented on code in PR #69593:
URL: https://github.com/apache/doris/pull/69593#discussion_r4373703267


##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/LocalTableValuedFunction.java:
##########
@@ -61,6 +61,8 @@ public class LocalTableValuedFunction extends 
ExternalFileTableValuedFunction {
     private boolean sharedStorage = false;
 
     public LocalTableValuedFunction(Map<String, String> properties) throws 
AnalysisException {
+        checkAccess();

Review Comment:
   [P2] Update the remaining local-glob regression expectations
   
   `test_parquet_meta_tvf.groovy:271-276` still runs 
`order_qt_parquet_file_metadata_local_glob` expecting success. 
`ParquetMetadataTableValuedFunction.expandSingleGlob()` constructs 
`LocalTableValuedFunction` for that local wildcard, so this new check always 
throws `LOCAL TVF is disabled` and aborts the p0 suite. The no-match local-glob 
case at lines 516-523 also still expects `failed to glob`. Adapt those two 
expectations to the disabled behavior while keeping the literal-local and 
remote metadata cases active.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to