github-actions[bot] commented on code in PR #69624:
URL: https://github.com/apache/doris/pull/69624#discussion_r4375410674
##########
cloud/src/recycler/recycler.h:
##########
@@ -65,10 +65,8 @@ int64_t calculate_tmp_rowset_expired_time(
struct RecyclerThreadPoolGroup {
RecyclerThreadPoolGroup() = default;
RecyclerThreadPoolGroup(std::shared_ptr<SimpleThreadPool> s3_producer_pool,
- std::shared_ptr<SimpleThreadPool>
recycle_tablet_pool,
std::shared_ptr<SimpleThreadPool>
group_recycle_function_pool)
Review Comment:
[P1] Update all callers when removing the tablet pool parameter
The constructor now accepts two pools, but `Recycler::Recycler` still passes
three at `recycler.cpp:307`, including `recycle_tablet_pool`, whose declaration
this PR deletes. This prevents the production `Recycler` library from
compiling. The recycler test fixtures/benchmark, `meta_service_test`, and
`txn_lazy_commit_test` also retain three-argument calls, so fixing the
production call alone still leaves the tests uncompilable. Update every caller
and remove the obsolete tablet-pool setup together with this signature change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
