github-actions[bot] commented on code in PR #69554:
URL: https://github.com/apache/doris/pull/69554#discussion_r4377101036
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/ErrorTabletInfo.java:
##########
@@ -47,4 +48,16 @@ public static List<ErrorTabletInfo>
fromThrift(List<TErrorTabletInfo> errorTable
}
return errorInfos;
}
+
+ public static List<TTabletCommitInfo> toInvolvedTabletCommitInfos(
+ List<TErrorTabletInfo> errorTabletInfos) {
+ List<TTabletCommitInfo> commitInfos = Lists.newArrayList();
+ for (TErrorTabletInfo errorInfo : errorTabletInfos) {
+ if (errorInfo.isSetTabletId()) {
+ commitInfos.add(new TTabletCommitInfo(
Review Comment:
[P2] Keep untouched tablet errors out of partition participation
An unqualified legacy INSERT whose rows belong only to B also plans A. Let A
have three selected replicas and required=2, and let one A backend fail its
writer-open RPC after planning while every B replica stays healthy.
`mark_as_failed(-1)` records A's tablet despite no row being routed there, and
successful channel closes export that diagnostic. The two healthy A writers are
cancelled because EOS contains only B, so A has no successful commit infos.
Converting this error to `(A,-1)` makes `checkCommitStatus()` include A and
reject the load with zero successful replicas, although its only touched
partition met quorum. Both `Coordinator` and `LoadContext` call this
conversion. Derive participation from actually routed partitions, or
distinguish planned-only diagnostics, and add a B-only load with one tolerated
open failure on untouched A.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
