Gabriel39 commented on PR #69646: URL: https://github.com/apache/doris/pull/69646#issuecomment-6434017044
The review follow-ups were based on an unnecessarily strong requirement: preserving potential exceptions on rows that a valid TopN bound excludes. That requirement is withdrawn. Such rows need not be evaluated or materialized, while executed failures still propagate normally. The PR description now makes this intended behavior explicit. The unnecessary FE expression whitelist and generic table-mapping/reordering flag are removed. FE production behavior is restored to the pre-PR base; only the TopN ZoneMap capability and Parquet scheduling remain as production changes. Reader integration covers output evolution, strict native DATE conversion and hidden Iceberg equality-delete conversion, with controls that still fail whenever the invalid group is required. This supersedes the error-preservation rationale in my earlier replies. Result correctness, secondary-key equality, NULL placement, physical row/delete coordinates and conservative statistics fallbacks remain required. The prior blanket visitor stop also caused an actual regression in the existing grouped-key aggregation EXPLAIN check: `TOPN OPT` disappeared. Restoring traversal fixes the cause; new FE coverage includes aggregation, aggregation with HAVING/join, and grouping sets, without weakening the existing SQL regression assertions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
