github-actions[bot] commented on code in PR #69376: URL: https://github.com/apache/doris/pull/69376#discussion_r4384729796
########## be/test/exec/sink/writer/iceberg/iceberg_partition_writer_test.cpp: ########## @@ -20,6 +20,7 @@ #include <optional> +#include "common/sync_point.h" Review Comment: [P1] Use the existing sync-point header path The header is `common/cpp/sync_point.h`, and BE adds `common/` as an include root (`be/CMakeLists.txt`), so this must be `#include "cpp/sync_point.h"`, as in the other BE callers. No `common/sync_point.h` exists at the configured include roots. Because `be/test/CMakeLists.txt` includes this file in the `doris_be_test` target, the new include causes a missing-header compilation error and blocks the BE unit-test build before the regression can run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
